-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support installing packages dependent on LabVIEW 2021 #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtzoeller
approved these changes
Nov 30, 2021
PaulDanH
approved these changes
Nov 30, 2021
DStavilaNI
added a commit
that referenced
this pull request
Dec 8, 2021
* - Finishded SE PPL Build Specs - Refactored Help File API - Updated the XML Configuration file * Finished beta implementation for the FPGA Addon Engine: - Engine library refactoring - PPL Build Spec for the Engine - XML File update * Dependencies clean-up * Bug Fix wihtin the engine - cluster conversion representation. Input cluster array was set to fixed size when creating the subVI * - Removed the extra build specs. Only Windows and Linux X64 are currently available, in line with the future target support policy - Updated the XML file * - Begun implementation of the "LVLIBP CD XML Updater" - BuildSpecs Update * - Began implementation of the Project XML Editor. Unfinished. - Built basic API * Implemented a recursive algorythm to identify the nodes of interest within the Configuration XML File * Alfa implementation of the post-step build tool - Code might still require refactoring and some additional error handling * Bumped the FPGA Addon version to 3.3.1 * - Finished implmenting initial mutation code for the 3.3.1 version. The RT Driver paths are now removed at Load time ( ActionVIOnLoad.vi .... if the paths exist) and are set dynamically before deployment (ActionVIOnCompile) - Refactor of the "ActionVIOnLoad" to simplify the code. - Updated the FPGA Addon Configuration XML * Small bug-fix (added removal for "Driver VI Path_4") * Updated the Configuration XML file * Updated the Set RIO INI Key.vi * Final update of the Set RIO INI Key.vi * - Enabled build for 64 bit LabVIEW - Removed build support for LabVIEW 2018 * Updated the targets.ini files -> removed Pharlap test targets * Bug Fix * Updated the targets.ini for the FPGA Register IO Tests * Added Target Configuration token to the ini file * Removed unnecessary build specs (llbs) * Updated the test API for the FPGA Register IO tests * - Removed bundled dependencies - Replaced Linux cRIO with a Linux PXI x64 target * Updated project RT Target properties * Bug fixes to ensure tests compatibility with VS2021 * Implemented mutation code for system definition files - required for tests for the 3.3.1 version of the FPGA Addon custom device * class libary clean-up * Applied mutation code to all of the system tests * Support installing packages dependent on LabVIEW 2021 (#141) * Fix LabVIEW package dependencies in control files for scripting * Fix LabVIEW bitness install paths for 64-bit * Update Jenkinsfile to prevent build failures due to diff call * Refactored the CD XML Updater tool, to allow for easier unit testing. * Implemented a basic unit tests + Assets for the "LVLIBP CD XML Updater" utility * Implemented the final version of the test * BD cleanup * - Added extra VIs for error testing (extra test cases). - Added error handling API - Some small refactoring for the API - Renamed the test class Co-authored-by: XenderMd <[email protected]> Co-authored-by: Karl-G1 <[email protected]>
DStavilaNI
added a commit
that referenced
this pull request
Dec 8, 2021
* - Finishded SE PPL Build Specs - Refactored Help File API - Updated the XML Configuration file * Finished beta implementation for the FPGA Addon Engine: - Engine library refactoring - PPL Build Spec for the Engine - XML File update * Dependencies clean-up * Bug Fix wihtin the engine - cluster conversion representation. Input cluster array was set to fixed size when creating the subVI * - Removed the extra build specs. Only Windows and Linux X64 are currently available, in line with the future target support policy - Updated the XML file * - Begun implementation of the "LVLIBP CD XML Updater" - BuildSpecs Update * - Began implementation of the Project XML Editor. Unfinished. - Built basic API * Implemented a recursive algorythm to identify the nodes of interest within the Configuration XML File * Alfa implementation of the post-step build tool - Code might still require refactoring and some additional error handling * Bumped the FPGA Addon version to 3.3.1 * - Finished implmenting initial mutation code for the 3.3.1 version. The RT Driver paths are now removed at Load time ( ActionVIOnLoad.vi .... if the paths exist) and are set dynamically before deployment (ActionVIOnCompile) - Refactor of the "ActionVIOnLoad" to simplify the code. - Updated the FPGA Addon Configuration XML * Small bug-fix (added removal for "Driver VI Path_4") * Updated the Configuration XML file * Updated the Set RIO INI Key.vi * Final update of the Set RIO INI Key.vi * - Enabled build for 64 bit LabVIEW - Removed build support for LabVIEW 2018 * Updated the targets.ini files -> removed Pharlap test targets * Bug Fix * Updated the targets.ini for the FPGA Register IO Tests * Added Target Configuration token to the ini file * Removed unnecessary build specs (llbs) * Updated the test API for the FPGA Register IO tests * - Removed bundled dependencies - Replaced Linux cRIO with a Linux PXI x64 target * Updated project RT Target properties * Bug fixes to ensure tests compatibility with VS2021 * Implemented mutation code for system definition files - required for tests for the 3.3.1 version of the FPGA Addon custom device * class libary clean-up * Applied mutation code to all of the system tests * Support installing packages dependent on LabVIEW 2021 (#141) * Fix LabVIEW package dependencies in control files for scripting * Fix LabVIEW bitness install paths for 64-bit * Update Jenkinsfile to prevent build failures due to diff call * Refactored the CD XML Updater tool, to allow for easier unit testing. * Implemented a basic unit tests + Assets for the "LVLIBP CD XML Updater" utility * Implemented the final version of the test * BD cleanup * - Added extra VIs for error testing (extra test cases). - Added error handling API - Some small refactoring for the API - Renamed the test class * Updated the setup and the tearDown methods Co-authored-by: XenderMd <[email protected]> Co-authored-by: Karl-G1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Support installing packages dependent on LabVIEW 2021 by targeting the correct bitness and package name.
Fix duplicated package name string between examples and scripting packages.
Why should this Pull Request be merged?
Fix ATS execution by allowing 2021 scripting support to be installed.
What testing has been done?
Verified packages built and installed on both LV 2020 32-bit and 2021 64-bit.
Verified examples could be run in 2021.